Skip to content

Rand affine fix#4528

Merged
wyli merged 6 commits intoProject-MONAI:feature/MetaTensorfrom
rijobro:RandAffine_fix
Jun 20, 2022
Merged

Rand affine fix#4528
wyli merged 6 commits intoProject-MONAI:feature/MetaTensorfrom
rijobro:RandAffine_fix

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented Jun 17, 2022

Transforms should only append once, this fixes RandAffined.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

rijobro added 2 commits June 16, 2022 16:15
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested a review from wyli June 17, 2022 11:57
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 17, 2022

Hi @rijobro, is this a non-breaking refactoring to clean up the API, or a fix for some functionality bugs?

@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented Jun 17, 2022

Bug fix!

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are some typing errors otherwise looks good

@wyli wyli merged commit db9e49b into Project-MONAI:feature/MetaTensor Jun 20, 2022
@rijobro rijobro deleted the RandAffine_fix branch June 20, 2022 13:37
@rijobro rijobro mentioned this pull request Jun 20, 2022
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants