Skip to content

add ngc to PATH#4517

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
YanxuanLiu:update_dockerfile_ngc_url
Jun 16, 2022
Merged

add ngc to PATH#4517
wyli merged 3 commits intoProject-MONAI:devfrom
YanxuanLiu:update_dockerfile_ngc_url

Conversation

@YanxuanLiu
Copy link
Copy Markdown
Collaborator

Fixes #4507

Description

Root cause

the executable binary needs to be put in same folder with devpendences.

Solution
  1. add opt/tools and opt/tools/ngc-cli to PATH
  2. remove cp ngc-cli/ngc ngc

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@YanxuanLiu YanxuanLiu requested review from wyli and yiheng-wang-nv and removed request for yiheng-wang-nv June 16, 2022 10:22
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 16, 2022

/build

@wyli wyli enabled auto-merge (squash) June 16, 2022 10:27
@wyli wyli merged commit 0b6af0b into Project-MONAI:dev Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker image build error

2 participants