Skip to content

Fixed generalized dice score#4511

Merged
wyli merged 1 commit intoProject-MONAI:devfrom
jlcsilva:4510-wrong-generalized-dice-score
Jun 15, 2022
Merged

Fixed generalized dice score#4511
wyli merged 1 commit intoProject-MONAI:devfrom
jlcsilva:4510-wrong-generalized-dice-score

Conversation

@jlcsilva
Copy link
Copy Markdown
Contributor

Signed-off-by: João Lourenço Silva [email protected]

Fixes #4510 .

Description

Fixed generalized dice score metric to be 1 when denominator is 1 and prediction is empty, and 1 if denominator is 0 but prediction is not empty.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • [] Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • [] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

…on is empty, and 0 if denominator is 0 but prediction is not empty

Signed-off-by: João Lourenço Silva <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 15, 2022

/build

@wyli wyli enabled auto-merge (squash) June 15, 2022 18:09
@wyli wyli merged commit 4215599 into Project-MONAI:dev Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong generalized dice score metric when denominator is 0 but prediction is non-empty

2 participants