Skip to content

changed ngc download url#4508

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
YanxuanLiu:update_dockerfile_ngc_url
Jun 15, 2022
Merged

changed ngc download url#4508
wyli merged 2 commits intoProject-MONAI:devfrom
YanxuanLiu:update_dockerfile_ngc_url

Conversation

@YanxuanLiu
Copy link
Copy Markdown
Collaborator

@YanxuanLiu YanxuanLiu commented Jun 15, 2022

Fixes #4507

Description

Root cause

ngc moved from ./ngc to ./ngc-cli/ngc
ngc.md5 renamed to ngc-cli.md5
so the files cannot be found.

Solution
  1. copy /opt/tools/ngc-cli/ngc to /opt/tools/ngc to make sure /opt/tools/ngc exist
  2. fixed the md5 file name, and replaced md5 check commands to official recommonded.
  3. changed ngc download url to https://ngc.nvidia.com/downloads/ngccli_linux.zip, in case ngccli_cat_linux.zip is abandoned.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 15, 2022

@YanxuanLiu YanxuanLiu force-pushed the update_dockerfile_ngc_url branch from 47eb267 to ddc0cee Compare June 15, 2022 10:08
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 15, 2022

/build

@wyli wyli enabled auto-merge (squash) June 15, 2022 10:10
@wyli wyli merged commit ed233d9 into Project-MONAI:dev Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docker image build error

2 participants