Skip to content

Add Unified Focal Loss#4488

Merged
wyli merged 6 commits intoProject-MONAI:devfrom
JohnMasoner:dev
Jun 26, 2022
Merged

Add Unified Focal Loss#4488
wyli merged 6 commits intoProject-MONAI:devfrom
JohnMasoner:dev

Conversation

@JohnMasoner
Copy link
Copy Markdown
Contributor

@JohnMasoner JohnMasoner commented Jun 13, 2022 •
edited
Loading

Fixes #4413

Description

Add Unified Focal Loss, about the issue

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 13, 2022

thanks, please sign the commit https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work there are also some minor typing issues https://github.com/Project-MONAI/MONAI/runs/6858724085?check_suite_focus=true#step:7:532

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 14, 2022

Hi @danieltudosiu, could you help review this one if you have some time? thanks!

@danieltudosiu
Copy link
Copy Markdown
Contributor

danieltudosiu commented Jun 15, 2022

@wyli will have a look over the weekend.

wyli
wyli reviewed Jun 21, 2022
View reviewed changes
@JohnMasoner
Copy link
Copy Markdown
Contributor Author

JohnMasoner commented Jun 22, 2022

@wyli Thank you for reviewing the code. I'm thinking about whether to add multiple categories or just support binary segmentation only.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 22, 2022

thanks, I think the initial support of the binary cases is good (as long as we have the docstring and input check), we can create a new feature request/PR for multiclass extension

wyli
wyli reviewed Jun 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I only have a few minor comments about the documentation, otherwise we can merge these new modules.

@JohnMasoner
update the docmentation
ac4b9a5 
Signed-off-by: JohnMasoner <[email protected]>
@JohnMasoner
Copy link
Copy Markdown
Contributor Author

JohnMasoner commented Jun 25, 2022

@wyli thanks, you took the time to review my code. this has been a great help to me.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 25, 2022

/build

1 similar comment
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 26, 2022

/build

wyli
wyli reviewed Jun 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, the tests look good, please help fix the typos then I'll merge this one.

wyli
wyli approved these changes Jun 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 26, 2022

/build

@wyli wyli enabled auto-merge (squash) June 26, 2022 11:47
@wyli wyli merged commit 78f8e74 into Project-MONAI:dev Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unified Focal Loss

3 participants

@JohnMasoner @wyli @danieltudosiu