Skip to content

Fixing SliceInferer Issue#4482

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
ericspod:inferer_fix
Jun 10, 2022
Merged

Fixing SliceInferer Issue#4482
wyli merged 3 commits intoProject-MONAI:devfrom
ericspod:inferer_fix

Conversation

@ericspod
Copy link
Copy Markdown
Member

@ericspod ericspod commented Jun 10, 2022

Signed-off-by: Eric Kerfoot [email protected]

Description

SliceInferer had a bug that prevented it from being called multiple times because it modified a member variable. On each invocation a check was made to see if roi_size was 2D, if so it was extended to 3D thus if the inferer was called again this check would fail. This has been changed to check against the size of a copy of this variable instead.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@ericspod ericspod requested review from Nic-Ma and wyli June 10, 2022 15:54
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 10, 2022

/black

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 10, 2022

/build

@wyli wyli enabled auto-merge (squash) June 10, 2022 16:12
@wyli wyli merged commit 179e4de into Project-MONAI:dev Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants