Skip to content

4477 4478 iterables enhancements#4479

Merged
wyli merged 7 commits intoProject-MONAI:devfrom
wyli:fixes-iterable-datasets
Jun 10, 2022
Merged

4477 4478 iterables enhancements#4479
wyli merged 7 commits intoProject-MONAI:devfrom
wyli:fixes-iterable-datasets

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jun 10, 2022

Signed-off-by: Wenqi Li [email protected]

Fixes #4477
Fixes #4478

Description

  • skip ShuffleBuffer.set_random_state method (the seed controls the state)
  • GridPatchDataset's self.transform is left empty, because it's shared with the base class.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
wyli added 2 commits June 10, 2022 12:16
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jun 10, 2022

/build

@wyli wyli enabled auto-merge (squash) June 10, 2022 12:40
@wyli wyli merged commit e3b47fe into Project-MONAI:dev Jun 10, 2022
@wyli wyli deleted the fixes-iterable-datasets branch June 11, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

shufflebuffer is not compatible with the dataloader patch dataset transform should be applied to the patches only

2 participants