Skip to content

matshow3d: supports subplot axes input#4459

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:support-subplot
Jun 6, 2022
Merged

matshow3d: supports subplot axes input#4459
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:support-subplot

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Jun 5, 2022

Signed-off-by: Wenqi Li [email protected]

Description

issue identified during developing a tutorial Project-MONAI/tutorials#747

the current implementation of matshow3d doesn't support displaying multiple subplots within the same figure()

this PR enables, a typical usage of:

plt.subplot(1, 2, 1); matshow3d(im_a, fig=plt.gca())
plt.subplot(1, 2, 2); matshow3d(im_b, fig=plt.gca())

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jun 6, 2022

/build

@wyli wyli enabled auto-merge (squash) June 6, 2022 05:50
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Jun 6, 2022

/build

@wyli wyli merged commit f025193 into Project-MONAI:dev Jun 6, 2022
@wyli wyli deleted the support-subplot branch June 11, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants