Skip to content

New segmentation loss functions and metrics#4444

Merged
wyli merged 7 commits intoProject-MONAI:devfrom
jlcsilva:dev
Jun 3, 2022
Merged

New segmentation loss functions and metrics#4444
wyli merged 7 commits intoProject-MONAI:devfrom
jlcsilva:dev

Conversation

@jlcsilva
Copy link
Copy Markdown
Contributor

@jlcsilva jlcsilva commented Jun 2, 2022

Signed-off-by: João Lourenço Silva [email protected]

Description

Added Generalized Dice Focal Loss and Generalized Dice Score metric. Implemented function in metrics.utils to check whether tensors are binarized and refactored existing metrics to use it.

Status

Ready

Types of changes

  • [] Non-breaking change (fix or new feature that would not break existing functionality).
  • [x ] Breaking change (fix or new feature that would cause existing functionality to change).
  • [ x] New tests added to cover the changes.
  • [ x] Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • [ x] Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • [ x] In-line docstrings updated.
  • [ x] Documentation updated, tested make html command in the docs/ folder.

jlcsilva and others added 3 commits June 2, 2022 06:48
…to metrics. Added function to check whether tensors are binarized to metrics.util and refactored metrics to use it.

Signed-off-by: João Lourenço Silva <[email protected]>
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is in a good shape, could you clear the tests/testing_data in this PR? also, I put a comment for the input validation part...

jlcsilva added 2 commits June 2, 2022 18:17
…ame of the tensor as argument and issue warnings directly
…ons-and-metrics

Refactored monai.metrics.utils.is_binary_tensor function to receive n…
@jlcsilva
Copy link
Copy Markdown
Contributor Author

jlcsilva commented Jun 2, 2022

thanks, this is in a good shape, could you clear the tests/testing_data in this PR? also, I put a comment for the input validation part...

Didn't notice new files had been generated there. I think it is ok now

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 3, 2022

/integration-test
/build

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this improves metrics and losses and with all changes verified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants