Skip to content

Enhance ensure_tuple for corner cases#4439

Merged
wyli merged 11 commits intoProject-MONAI:devfrom
Nic-Ma:enhance-ensure-tuple
Jun 2, 2022
Merged

Enhance ensure_tuple for corner cases#4439
wyli merged 11 commits intoProject-MONAI:devfrom
Nic-Ma:enhance-ensure-tuple

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Jun 2, 2022

Description

Thanks for the feedback from @Can-Zhao , this PR enhanced the ensure_tuple API for some corner cases.
And added many unit tests.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 2, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Jun 2, 2022

/build

@Nic-Ma Nic-Ma changed the title Enhance ensure tuple for corner cases Enhance ensure_tuple for corner cases Jun 2, 2022
@wyli wyli force-pushed the enhance-ensure-tuple branch from 0b70821 to 6d5dda5 Compare June 2, 2022 09:04
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 2, 2022

/build

@wyli wyli enabled auto-merge (squash) June 2, 2022 09:11
wyli added 2 commits June 2, 2022 10:38
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the enhance-ensure-tuple branch from 6d5dda5 to 07e2ee4 Compare June 2, 2022 09:41
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 2, 2022

/build

1 similar comment
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 2, 2022

/build

@wyli wyli merged commit cfd1562 into Project-MONAI:dev Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants