Skip to content

4426 Enhance download_url and fixes error msg#4427

Merged
wyli merged 5 commits intoProject-MONAI:devfrom
yiheng-wang-nv:4426-enhance-download-url
Jun 1, 2022
Merged

4426 Enhance download_url and fixes error msg#4427
wyli merged 5 commits intoProject-MONAI:devfrom
yiheng-wang-nv:4426-enhance-download-url

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Jun 1, 2022

Fixes #4426

Fixes #4432

Description

This PR is used to enhance the download_url function by adding kwargs for gdown. The required version of gdown is also changed to make use of more new features.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv yiheng-wang-nv requested review from Nic-Ma, rijobro and wyli and removed request for Nic-Ma and wyli June 1, 2022 11:28
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv yiheng-wang-nv force-pushed the 4426-enhance-download-url branch from 918a2a8 to 2f15878 Compare June 1, 2022 11:29
@yiheng-wang-nv
Copy link
Copy Markdown
Contributor Author

/black

Signed-off-by: monai-bot <[email protected]>
@yiheng-wang-nv yiheng-wang-nv requested a review from Nic-Ma June 1, 2022 12:32
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, cc @Nic-Ma in case there are more comments

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli changed the title 4426 Enhance download_url 4426 Enhance download_url and fixes error msg Jun 1, 2022
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 1, 2022

/build

@wyli wyli enabled auto-merge (squash) June 1, 2022 16:51
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 1, 2022

/build

@wyli wyli merged commit d8d24ee into Project-MONAI:dev Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests.test_spatial_resample error Enhance download_url to support more gdown arguments

4 participants