Skip to content

Minor enhancement for several places#4409

Merged
wyli merged 14 commits intoProject-MONAI:devfrom
Nic-Ma:minor-enhancement
May 31, 2022
Merged

Minor enhancement for several places#4409
wyli merged 14 commits intoProject-MONAI:devfrom
Nic-Ma:minor-enhancement

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented May 31, 2022 •
edited
Loading

Description

This PR added several minor enhancements:

  1. Added missing doc for monai.bundle init_bundle.
  2. Corrected description for spatial shape example in the bundle doc.
  3. Updated wrong typehints in all the pad transforms.
  4. @rijobro already updated the Pad transform arg np_kwargs to kwargs for both numpy and torch APIs, this PR corrected 2 missing transforms for this change.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Nic-Ma and others added 11 commits February 1, 2021 19:15
@Nic-Ma
Merge pull request #19 from Project-MONAI/master
42a45e0 
merge master
@Nic-Ma
Merge pull request #32 from Project-MONAI/master
cd16a13 
merge master
@Nic-Ma
Merge pull request #180 from Project-MONAI/dev
6f87afd 
merge master
@Nic-Ma
Merge pull request #214 from Project-MONAI/dev
f398298 
merge master
@Nic-Ma
Merge pull request #397 from Project-MONAI/dev
ec463d6 
merge master
@Nic-Ma
Merge pull request #417 from Project-MONAI/dev
f30eb5c 
merge master
@Nic-Ma
[DLMED] improve several cases
c583097 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] update dict transform
6da1045 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] update utils
20c7876 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] fix flake8
4661665 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
[DLMED] fix docs
a65c15b 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 31, 2022

/black

@ericspod
Copy link
Copy Markdown
Member

ericspod commented May 31, 2022

Should we also change the URL for the schema file to https://github.com/Project-MONAI/MONAI-extra-test-data/releases/download/0.8.1/meta_schema_20220324.json?

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 31, 2022

Should we also change the URL for the schema file to https://github.com/Project-MONAI/MONAI-extra-test-data/releases/download/0.8.1/meta_schema_20220324.json?

Hi @ericspod ,

May I know where you think we should update?
I think the test data is already updated:
https://github.com/Project-MONAI/MONAI/blob/dev/tests/testing_data/metadata.json#L2

Thanks.

@ericspod
Copy link
Copy Markdown
Member

ericspod commented May 31, 2022

Sorry I meant the URL that's in md=b_specification.rst should be the one I gave rather than the temporary one that's given currently.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 31, 2022

Sorry I meant the URL that's in md=b_specification.rst should be the one I gave rather than the temporary one that's given currently.

Hi @ericspod ,

Sure, updated in the latest commit.

Thanks.

@Nic-Ma Nic-Ma marked this pull request as ready for review May 31, 2022 15:48
@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli and removed request for ericspod May 31, 2022 15:48
wyli
wyli approved these changes May 31, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

the docstring revision in transforms/croppad might cause some conflicts with #4371 cc @rijobro perhaps in #4371 please avoid updating the docstrings for now...

@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 31, 2022

/build

@wyli wyli enabled auto-merge (squash) May 31, 2022 18:42
@wyli wyli merged commit a737d58 into Project-MONAI:dev May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nic-Ma @ericspod @wyli