Define PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION only when protobuf>=4.0.0 is used #4397
Merged
wyli merged 5 commits intoProject-MONAI:devfrom May 30, 2022
Conversation
Contributor
Author
|
cc @wyli |
Contributor
|
Thanks @harupy, I understand the idea. Initially, I thought monai could remain agnostic about the probotuf versions (because monai doesn't directly depend on protobuf). Apparently now we couldn't avoid checking the version number of probobuf in the testing environments. Perhaps this is the only good way going forward. |
wyli
approved these changes
May 30, 2022
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
Signed-off-by: harupy <[email protected]>
harupy
force-pushed
the
conditionally-define-PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION
branch
from
ab546d9 to
cbbf269
Compare
harupy
changed the title
PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION only when protobuf>=4.0.0 is used PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION only when protobuf>=4.0.0 is used
Signed-off-by: harupy <[email protected]>
Contributor
|
thank you very much @harupy, I'll merge this one. |
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4375
Description
A few sentences describing the changes proposed in this pull request.
As suggested in mlflow/mlflow#5968 (comment),
PROTOCOL_BUFFERS_PYTHON_IMPLEMENTATION=pythonis only required inprotobuf >= 4.0.0.Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.