Skip to content

add random foreground crop for boxes#4388

Merged
wyli merged 13 commits intoProject-MONAI:devfrom
Can-Zhao:randfgcrop
Jun 2, 2022
Merged

add random foreground crop for boxes#4388
wyli merged 13 commits intoProject-MONAI:devfrom
Can-Zhao:randfgcrop

Conversation

@Can-Zhao
Copy link
Copy Markdown
Collaborator

@Can-Zhao Can-Zhao commented May 30, 2022

Signed-off-by: Can Zhao [email protected]

Fixes #3572 .

Description

add random foreground crop for boxes

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 30, 2022
@Can-Zhao Can-Zhao marked this pull request as ready for review May 30, 2022 09:55
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 30, 2022 09:55
@Can-Zhao Can-Zhao marked this pull request as draft May 30, 2022 09:57
@Can-Zhao Can-Zhao marked this pull request as ready for review May 30, 2022 16:42
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
It overall looks good to me now.
Put some minor comments inline.

Thanks.

@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

Can-Zhao commented Jun 2, 2022

/black

monai-bot and others added 2 commits June 2, 2022 04:54
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 2, 2022

/build

1 similar comment
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 2, 2022

/build

@wyli wyli enabled auto-merge (squash) June 2, 2022 10:25
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 2, 2022

/build

1 similar comment
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Jun 2, 2022

/build

@wyli wyli merged commit bbb35e2 into Project-MONAI:dev Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Box transforms

4 participants