Skip to content

Refactor Probability Map Producer Handler#4382

Merged
bhashemian merged 22 commits intoProject-MONAI:devfrom
bhashemian:update-prob-map
Jun 1, 2022
Merged

Refactor Probability Map Producer Handler#4382
bhashemian merged 22 commits intoProject-MONAI:devfrom
bhashemian:update-prob-map

Conversation

@bhashemian
Copy link
Copy Markdown
Member

@bhashemian bhashemian commented May 29, 2022 •
edited
Loading

Fixes #4381

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@bhashemian bhashemian marked this pull request as ready for review May 29, 2022 15:00
@bhashemian bhashemian requested review from Nic-Ma and wyli May 30, 2022 16:04
Nic-Ma
Nic-Ma reviewed May 30, 2022
View reviewed changes
@bhashemian bhashemian marked this pull request as draft May 30, 2022 22:13
@bhashemian bhashemian marked this pull request as ready for review May 31, 2022 13:54
@bhashemian bhashemian enabled auto-merge (squash) May 31, 2022 13:55
@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented May 31, 2022

@Nic-Ma, any other comments here? Otherwise, it should be ready to merge. Thanks

@bhashemian bhashemian mentioned this pull request Jun 1, 2022
Merged
7 tasks
Nic-Ma
Nic-Ma approved these changes Jun 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
Looks good to me except for minor comments inline.

Thanks.

@bhashemian
update doctrting
f31d09a 
Signed-off-by: Behrooz <[email protected]>
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jun 1, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Jun 1, 2022

/build

@bhashemian bhashemian merged commit 40373b2 into Project-MONAI:dev Jun 1, 2022
@bhashemian bhashemian deleted the update-prob-map branch June 1, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@wyli wyli Awaiting requested review from wyli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor ProbMapProducer

2 participants

@bhashemian @Nic-Ma