Skip to content

add RetinaNet network#4378

Merged
wyli merged 25 commits intoProject-MONAI:devfrom
Can-Zhao:detection_retinanet
May 30, 2022
Merged

add RetinaNet network#4378
wyli merged 25 commits intoProject-MONAI:devfrom
Can-Zhao:detection_retinanet

Conversation

@Can-Zhao
Copy link
Copy Markdown
Collaborator

@Can-Zhao Can-Zhao commented May 28, 2022 •
edited
Loading

Signed-off-by: Can Zhao [email protected]

Fixes #4383.
add retinanet

Description

add retinanet networks

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 28, 2022
@Can-Zhao Can-Zhao changed the title add retinanet add RetinaNet network May 28, 2022
@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

Can-Zhao commented May 28, 2022

/black

Can-Zhao added 4 commits May 28, 2022 16:01
@Can-Zhao
reformat
47c2858 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
clean unused par
5be201d 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
clean unused par
e819e76 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
clean unused par
394fbbe 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao Can-Zhao marked this pull request as ready for review May 28, 2022 21:48
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 29, 2022 03:28
wyli
wyli reviewed May 29, 2022
View reviewed changes
@wyli
fixes unit test
5c3ecc3 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the detection_retinanet branch from 664ef0b to 5c3ecc3 Compare May 29, 2022 12:21
Can-Zhao added 4 commits May 29, 2022 10:52
@Can-Zhao
remove base detection network abstract class
254614c 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
tested with detection pipeline
6ff3c8f 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
reformat
781fc74 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
fic doc
887c80a 
Signed-off-by: Can Zhao <[email protected]>
wyli
wyli approved these changes May 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New net arch with 2/3d support, torchscript support not tested.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 29, 2022

/build

@wyli wyli enabled auto-merge (squash) May 29, 2022 18:20
@Nic-Ma Nic-Ma disabled auto-merge May 30, 2022 06:18
Nic-Ma
Nic-Ma approved these changes May 30, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It overall looks good to me.
Put some minor comments inline.
I will disable the auto-merge for a while.

Thanks.

@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

Can-Zhao commented May 30, 2022

New net arch with 2/3d support, torchscript support not tested.

torchscript support has been tested now

@Can-Zhao
fix torchvision import
4c3f708 
Signed-off-by: Can Zhao <[email protected]>
Nic-Ma
Nic-Ma reviewed May 30, 2022
View reviewed changes
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 30, 2022

/build

@wyli wyli enabled auto-merge (squash) May 30, 2022 15:22
@wyli wyli merged commit 9133e35 into Project-MONAI:dev May 30, 2022
@Can-Zhao Can-Zhao deleted the detection_retinanet branch May 30, 2022 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@wyli wyli wyli approved these changes

Assignees

No one assigned

Labels

Feature request

Projects

None yet

Milestone

Detection module [P0]

Development

Successfully merging this pull request may close these issues.

Add RetinaNet network

3 participants

@Can-Zhao @wyli @Nic-Ma