Skip to content

4346 Enhance contribution guide for optional package#4367

Merged
Nic-Ma merged 11 commits intoProject-MONAI:devfrom
Nic-Ma:4346-enhance-contribution-doc
May 28, 2022
Merged

4346 Enhance contribution guide for optional package#4367
Nic-Ma merged 11 commits intoProject-MONAI:devfrom
Nic-Ma:4346-enhance-contribution-doc

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented May 27, 2022

Fixes #4346 .

Description

According to the feedback from several recent new contributors, this PR added the description for optional package.
And also fixed a link error in installation.md doc.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli force-pushed the 4346-enhance-contribution-doc branch from bb0d751 to 1230cc5 Compare May 27, 2022 20:09
@wyli wyli requested a review from ericspod May 27, 2022 20:09
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some more info, please feel free to revise...

@Nic-Ma Nic-Ma changed the title [WIP] 4346 Enhance contribution guide for optional package 4346 Enhance contribution guide for optional package May 28, 2022
@Nic-Ma Nic-Ma marked this pull request as ready for review May 28, 2022 01:23
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 28, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 28, 2022

/build

1 similar comment
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 28, 2022

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) May 28, 2022 05:53
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 28, 2022

/build

@Nic-Ma Nic-Ma merged commit 827e1e5 into Project-MONAI:dev May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance contribution guide for optional packages

3 participants