Skip to content

4348 Improve doc and unit tests for "correct center" of crop transforms#4362

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:4348-improve-crop-doc
May 27, 2022
Merged

4348 Improve doc and unit tests for "correct center" of crop transforms#4362
wyli merged 8 commits intoProject-MONAI:devfrom
Nic-Ma:4348-improve-crop-doc

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented May 26, 2022

Fixes #4348 .

Description

Thanks for @YerePhy 's feedback, this PR improved the doc-string and added unit tests for the "correct center" case of random cropping transforms.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma marked this pull request as ready for review May 26, 2022 17:27
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 26, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented May 26, 2022

/build

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli May 26, 2022 17:29
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 26, 2022

/build

@wyli wyli enabled auto-merge (squash) May 26, 2022 23:47
@wyli wyli merged commit 1cfec68 into Project-MONAI:dev May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants