Skip to content

4323 deprecate SegmentationSaver, TorchVisionFullyConvModel#4347

Merged
wyli merged 5 commits intoProject-MONAI:devfrom
wyli:deprecated
May 26, 2022
Merged

4323 deprecate SegmentationSaver, TorchVisionFullyConvModel#4347
wyli merged 5 commits intoProject-MONAI:devfrom
wyli:deprecated

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented May 25, 2022

Signed-off-by: Wenqi Li [email protected]

part of #4323 for 0.9 release

Description

remove the promised deprecation

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli marked this pull request as ready for review May 25, 2022 19:35
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented May 26, 2022

Hi @wyli ,

Should we also remove other deprecated APIs? May I know why only remove SegmentationSaver and TorchVisionFullyConvModel?

Thanks.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented May 26, 2022

Hi @wyli ,

Should we also remove other deprecated APIs? May I know why only remove SegmentationSaver and TorchVisionFullyConvModel?

Thanks.

We put v0.9 in the 'removed' field of the warning msg

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented May 26, 2022

/build

@wyli wyli enabled auto-merge (squash) May 26, 2022 21:18
@wyli wyli merged commit 6b4d9eb into Project-MONAI:dev May 26, 2022
@wyli wyli deleted the deprecated branch May 27, 2022 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants