4323 deprecate SegmentationSaver, TorchVisionFullyConvModel#4347
Merged
wyli merged 5 commits intoProject-MONAI:devfrom May 26, 2022
Merged
4323 deprecate SegmentationSaver, TorchVisionFullyConvModel#4347wyli merged 5 commits intoProject-MONAI:devfrom
wyli merged 5 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Contributor
|
Hi @wyli , Should we also remove other deprecated APIs? May I know why only remove Thanks. |
Contributor
Author
We put v0.9 in the 'removed' field of the warning msg |
Nic-Ma
approved these changes
May 26, 2022
Contributor
Author
|
/build |
1 task
This was referenced May 27, 2022
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
part of #4323 for 0.9 release
Description
remove the promised deprecation
SaveImageinstead)MONAI/monai/handlers/segmentation_saver.py
Line 29 in eb60b9c
TorchVisionFCModelinstead)MONAI/monai/networks/nets/torchvision_fc.py
Line 77 in eb60b9c
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.