Skip to content

add feature pyramid network (FPN) for detection#4342

Merged
wyli merged 23 commits intoProject-MONAI:devfrom
Can-Zhao:fpn
May 26, 2022
Merged

add feature pyramid network (FPN) for detection#4342
wyli merged 23 commits intoProject-MONAI:devfrom
Can-Zhao:fpn

Conversation

@Can-Zhao
Copy link
Copy Markdown
Collaborator

@Can-Zhao Can-Zhao commented May 25, 2022 •
edited
Loading

Signed-off-by: Can Zhao [email protected]

Fixes #4341 .

Description

add feature pyramid network (FPN) for detection

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Can-Zhao
add FPN
e4e78ce 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 25, 2022
@Can-Zhao Can-Zhao marked this pull request as ready for review May 25, 2022 06:05
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented May 25, 2022

Hi @Can-Zhao ,

Please import torchvision as optional import, refer to:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/networks/nets/torchvision_fc.py#L17

Thanks.

@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

Can-Zhao commented May 25, 2022

Hi @Can-Zhao ,

Please import torchvision as optional import, refer to: https://github.com/Project-MONAI/MONAI/blob/dev/monai/networks/nets/torchvision_fc.py#L17

Thanks.

Thank you! Done

Can-Zhao and others added 5 commits May 25, 2022 12:45
@Can-Zhao
typo
5f1afb5 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
add torchvision license
304e90b 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
license
65f4ecf 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
docstring
8d7bac4 
Signed-off-by: Can Zhao <[email protected]>
@wyli
mv to monai.networks
7a2827e 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
mv docs to networks.rst
ed854b5 
Signed-off-by: Wenqi Li <[email protected]>
wyli
wyli approved these changes May 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backbone adapted from torchvision with 2d/3d support

@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 26, 2022

/build

@wyli wyli enabled auto-merge (squash) May 26, 2022 16:35
@wyli wyli merged commit a5ca749 into Project-MONAI:dev May 26, 2022
@Can-Zhao Can-Zhao deleted the fpn branch May 26, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

@mibaumgartner mibaumgartner Awaiting requested review from mibaumgartner

@dongyang0122 dongyang0122 Awaiting requested review from dongyang0122

Assignees

No one assigned

Labels

Feature request

Projects

None yet

Milestone

Detection module [P0]

Development

Successfully merging this pull request may close these issues.

Add feature pyramid network for detection

3 participants

@Can-Zhao @Nic-Ma @wyli