Skip to content

4314 Enhance UnetResBlock#4317

Merged
wyli merged 1 commit intoProject-MONAI:devfrom
yiheng-wang-nv:4314-enhance-unetresblock
May 23, 2022
Merged

4314 Enhance UnetResBlock#4317
wyli merged 1 commit intoProject-MONAI:devfrom
yiheng-wang-nv:4314-enhance-unetresblock

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

Signed-off-by: Yiheng Wang [email protected]

Fixes #4314 .

Description

This PR is used to enhance UnetResBlock and avoid creating unnecessary norm and conv layers when downsample is not used.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 23, 2022

/build

@wyli wyli enabled auto-merge (squash) May 23, 2022 07:14
@wyli wyli merged commit 46f3074 into Project-MONAI:dev May 23, 2022
@yiheng-wang-nv yiheng-wang-nv deleted the 4314-enhance-unetresblock branch June 28, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnetResBlock may create unused parameters if downsampling not used

2 participants