Skip to content

Add spatial crop and clip box to Box utils#4316

Merged
wyli merged 14 commits intoProject-MONAI:devfrom
Can-Zhao:box_utils
May 24, 2022
Merged

Add spatial crop and clip box to Box utils#4316
wyli merged 14 commits intoProject-MONAI:devfrom
Can-Zhao:box_utils

Conversation

@Can-Zhao
Copy link
Copy Markdown
Collaborator

@Can-Zhao Can-Zhao commented May 22, 2022

Fixes #3571.

Description

Add spatial crop and clip box to Box utils.

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Can-Zhao added 2 commits May 22, 2022 17:39
@Can-Zhao
add clip box to image into box_utils
e4d9217 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao
add doc
3adc39d 
Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 22, 2022
@Can-Zhao Can-Zhao marked this pull request as ready for review May 22, 2022 22:12
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 22, 2022 22:12
@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

Can-Zhao commented May 23, 2022

/black

@Can-Zhao
black
11aeb01 
Signed-off-by: Can Zhao <[email protected]>
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented May 23, 2022

Should we put these 2 utilises in the box_ops.py for transforms? they look like transform operations.

Thanks.

@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

Can-Zhao commented May 23, 2022

Should we put these 2 utilises in the box_ops.py for transforms? they look like transform operations.

Thanks.

clip_boxes_to_image is also used in network inference. We clip the boxes before doing NMS

Nic-Ma
Nic-Ma approved these changes May 24, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, put some minor comments inline.

Thanks.

@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

Can-Zhao commented May 24, 2022

/black

@monai-bot
[MONAI] code formatting
e0b3be3 
Signed-off-by: monai-bot <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 24, 2022

/build

@wyli wyli enabled auto-merge (squash) May 24, 2022 15:30
@wyli
workaround autofix
df2d7ae 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 24, 2022

/build

@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 24, 2022

/build

@wyli wyli merged commit 6c8e4ab into Project-MONAI:dev May 24, 2022
@Can-Zhao Can-Zhao deleted the box_utils branch May 24, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@wyli wyli Awaiting requested review from wyli

Assignees

No one assigned

Labels

Feature request

Projects

None yet

Milestone

Detection module [P0]

Development

Successfully merging this pull request may close these issues.

Box utils components

4 participants

@Can-Zhao @Nic-Ma @wyli @monai-bot