multiprocessing test metatensor#4308
Merged
wyli merged 3 commits intoProject-MONAI:devfrom May 23, 2022
Merged
Conversation
Contributor
|
Should these not go into |
rijobro
reviewed
May 20, 2022
fixes unit test update reduce fixes mypy Signed-off-by: Wenqi Li <[email protected]>
wyli
force-pushed
the
test-multiprocessing-metatensor
branch
from
9763ee6 to
cc9bc51
Compare
Contributor
Author
thanks @rijobro, I think this one is now good for >>> from monai.data import MetaTensor
>>> MetaTensor([1.0], device="cpu")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: __init__() got an unexpected keyword argument 'device' |
rijobro
reviewed
May 23, 2022
rijobro
approved these changes
May 23, 2022
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Description
may need to register new logic to the pickler
according to https://github.com/pytorch/pytorch/blob/53e0d7a3bae621ef0d07cfd44957736e9149dd8e/torch/_tensor.py#L77-L79
cc @rijobro
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.