Skip to content

fix RandAffine with randomize==False#4304

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
rijobro:RandAfffine_randomize
May 20, 2022
Merged

fix RandAffine with randomize==False#4304
wyli merged 4 commits intoProject-MONAI:devfrom
rijobro:RandAfffine_randomize

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented May 20, 2022

Fixes #4303.

Description

Pass the randomize flag on to RandAffineGrid so that it randomises at the correct moment. Unit test added to ensure this.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.

@rijobro rijobro requested review from Nic-Ma, ericspod and wyli May 20, 2022 09:06
@rijobro
Copy link
Copy Markdown
Contributor Author

rijobro commented May 20, 2022

@fluentgcc Thanks for spotting the bug, this should solve the issue.

Signed-off-by: Richard Brown <[email protected]>
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.
Looks good to me, put minor comments inline.

Thanks.

Signed-off-by: Richard Brown <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 20, 2022

/build

@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 20, 2022

/build

@wyli wyli enabled auto-merge (squash) May 20, 2022 10:17
@wyli wyli merged commit 1d5e85a into Project-MONAI:dev May 20, 2022
@rijobro rijobro deleted the RandAfffine_randomize branch May 23, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RandAffine cannot return same transform when randomize param set to False.

3 participants