Skip to content

remove_extra_metadata etc transforms/utils.py -> data/utils.py#4296

Merged
wyli merged 9 commits intoProject-MONAI:feature/MetaTensorfrom
rijobro:remove_extra_metadata_to_data_submodule
May 19, 2022
Merged

remove_extra_metadata etc transforms/utils.py -> data/utils.py#4296
wyli merged 9 commits intoProject-MONAI:feature/MetaTensorfrom
rijobro:remove_extra_metadata_to_data_submodule

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented May 19, 2022

Fixes circular import cf #4294 (comment).

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).

@rijobro rijobro requested a review from wyli May 19, 2022 13:27
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 19, 2022

/black

Signed-off-by: monai-bot <[email protected]>
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, there are a few issues because of the merging conflicts according to the tests, could you help fix @rijobro?

rijobro added 7 commits May 19, 2022 16:48
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
@wyli wyli merged commit 1bd2c8c into Project-MONAI:feature/MetaTensor May 19, 2022
@rijobro rijobro deleted the remove_extra_metadata_to_data_submodule branch May 19, 2022 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants