Skip to content

4293 local pre-commit check support#4292

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
wyli:pre-commit
May 19, 2022
Merged

4293 local pre-commit check support#4292
wyli merged 8 commits intoProject-MONAI:devfrom
wyli:pre-commit

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented May 19, 2022 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

Fixes #4293

Description

  • update pre-commit config for additional code checking
  • adds recommit option to runtests.sh to allow for local checking

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli mentioned this pull request May 19, 2022
Closed
@wyli wyli changed the title local pre-commit check support 4293 local pre-commit check support May 19, 2022
@wyli wyli marked this pull request as ready for review May 19, 2022 12:22
@rijobro
Copy link
Copy Markdown
Contributor

rijobro commented May 19, 2022

Great addition. The hash changes seem unrelated, are they intentional?

@rijobro
Copy link
Copy Markdown
Contributor

rijobro commented May 19, 2022

Will the pre_commit also check the DCO?

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented May 19, 2022

Great addition. The hash changes seem unrelated, are they intentional?

those are auto format changes for json files. DCO is not supported, I actually looked into it. DCO check could be done with git commit hook scripts envoyproxy/envoy#2283 but I don't know how robust the script is.

rijobro
rijobro approved these changes May 19, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented May 19, 2022

/build

@wyli wyli enabled auto-merge (squash) May 19, 2022 19:02
@wyli wyli merged commit 5a5d47f into Project-MONAI:dev May 19, 2022
@wyli wyli deleted the pre-commit branch May 19, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rijobro rijobro rijobro approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

@ericspod ericspod Awaiting requested review from ericspod

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

enhance pre-commit check integration

2 participants

@wyli @rijobro