add box center related funcs to box_utils#4290
Merged
wyli merged 7 commits intoProject-MONAI:devfrom May 19, 2022
Merged
Conversation
Signed-off-by: Can Zhao <[email protected]>
Signed-off-by: Can Zhao <[email protected]>
Collaborator
Author
|
/black |
Signed-off-by: Can Zhao <[email protected]>
Nic-Ma
reviewed
May 19, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the quick PR.
Please confirm all the function names, especially "box" vs "boxes", "center" vs "centers", etc.
Once we released the APIs, it's hard to change them.
Thanks.
Signed-off-by: Can Zhao <[email protected]>
Signed-off-by: Can Zhao <[email protected]>
Collaborator
Author
Thank you! I have updated them |
Collaborator
Author
|
/black |
Nic-Ma
reviewed
May 19, 2022
Nic-Ma
approved these changes
May 19, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the quick update.
Looks good to me, put some minor comments inline.
Thanks.
Signed-off-by: Can Zhao <[email protected]>
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Can Zhao [email protected]
Fixes #3571.
Description
add box center related funcs to box_utils
Status
Ready/Work in progress/Hold
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.