Skip to content

add box iou into box utils#4289

Merged
wyli merged 17 commits intoProject-MONAI:devfrom
Can-Zhao:detection_pr
May 20, 2022
Merged

add box iou into box utils#4289
wyli merged 17 commits intoProject-MONAI:devfrom
Can-Zhao:detection_pr

Conversation

@Can-Zhao
Copy link
Copy Markdown
Collaborator

@Can-Zhao Can-Zhao commented May 18, 2022

Signed-off-by: Can Zhao [email protected]

Fixes #3571.

Description

add box iou into box utils

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Can Zhao <[email protected]>
@Can-Zhao Can-Zhao requested review from Nic-Ma and wyli May 18, 2022 20:39
@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 18, 2022
@Can-Zhao Can-Zhao changed the title add box iou funcs add box iou into box utils May 18, 2022
@Can-Zhao Can-Zhao marked this pull request as ready for review May 18, 2022 21:28
@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

/black

Signed-off-by: monai-bot <[email protected]>
@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

/build

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Just some minor comments inline.
I didn't check the computation carefully, @wyli could you please help confirm them?

Thanks in advance.

@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented May 20, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented May 20, 2022

/build

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli enabled auto-merge (squash) May 20, 2022 08:47
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 20, 2022

/build

@wyli wyli merged commit a129499 into Project-MONAI:dev May 20, 2022
@Can-Zhao Can-Zhao deleted the detection_pr branch May 20, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Box utils components

4 participants