Skip to content

track transforms#4284

Merged
wyli merged 13 commits intoProject-MONAI:devfrom
rijobro:MetaTensor_track_transforms
May 19, 2022
Merged

track transforms#4284
wyli merged 13 commits intoProject-MONAI:devfrom
rijobro:MetaTensor_track_transforms

Conversation

@rijobro
Copy link
Copy Markdown
Contributor

@rijobro rijobro commented May 17, 2022

MetaTensor to track transforms. Can go straight into dev.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.

Signed-off-by: Richard Brown <[email protected]>
@rijobro rijobro requested review from Nic-Ma, ericspod and wyli May 17, 2022 12:58
rijobro added 2 commits May 17, 2022 14:25
Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks I put some comments for discussion

Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, it provides minimal API for tracking the applied operations (and necessary changes for #1749). looks good to me

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except for some minor comments.

Thanks.

rijobro added 3 commits May 18, 2022 16:25
Signed-off-by: Richard Brown <[email protected]>
…I into MetaTensor_track_transforms

Signed-off-by: Richard Brown <[email protected]>
Signed-off-by: Richard Brown <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 19, 2022

/build

@wyli wyli enabled auto-merge (squash) May 19, 2022 12:22
@wyli wyli merged commit d7767cd into Project-MONAI:dev May 19, 2022
@rijobro rijobro deleted the MetaTensor_track_transforms branch May 19, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants