4281 - adds zero_centered option to AffineTransform#4282
Merged
wyli merged 6 commits intoProject-MONAI:devfrom May 18, 2022
Merged
4281 - adds zero_centered option to AffineTransform#4282wyli merged 6 commits intoProject-MONAI:devfrom
AffineTransform#4282wyli merged 6 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
wyli
requested review from
Nic-Ma,
ericspod,
rijobro and
yiheng-wang-nv
and removed request for
Nic-Ma
Nic-Ma
approved these changes
May 18, 2022
Contributor
Nic-Ma
left a comment
Nic-Ma
left a comment
There was a problem hiding this comment.
Thanks for the quick update.
Looks good to me, put some minor comments inline.
Thanks.
Signed-off-by: Wenqi Li <[email protected]>
Contributor
Author
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wenqi Li [email protected]
Fixes #4281
AffineTransformonly allows for centre of rotation from the image origin.this PR adds the support of rotation around the spatial centre of the input image.
Affine'snorm_coordsoption to be consistent withAffineTransformsStatus
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.