Skip to content

Recursive NVTX Range#4270

Merged
bhashemian merged 12 commits intoProject-MONAI:devfrom
bhashemian:update-nvtx-range
May 18, 2022
Merged

Recursive NVTX Range#4270
bhashemian merged 12 commits intoProject-MONAI:devfrom
bhashemian:update-nvtx-range

Conversation

@bhashemian
Copy link
Copy Markdown
Member

@bhashemian bhashemian commented May 13, 2022 •
edited
Loading

Description

This PR adds recursive functionality to MONAI's NVTX Range. This enables annotating all individual transforms that are chained by using only one `Range(recursive=True).

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.

@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented May 13, 2022

You can find a use case here:
https://github.com/Project-MONAI/tutorials/blob/cb830be0a36cee03b18bb4591064408e8e44f78f/pathology/tumor_detection/ignite/camelyon_train_evaluate_nvtx_profiling.py#L99

@bhashemian bhashemian requested review from Nic-Ma and wyli May 13, 2022 17:04
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 13, 2022

/build

@wyli wyli enabled auto-merge (squash) May 13, 2022 21:41
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 13, 2022

/build

wyli
wyli reviewed May 14, 2022
View reviewed changes
wyli
wyli reviewed May 14, 2022
View reviewed changes
@bhashemian
address comment
1f19703 
Signed-off-by: Behrooz <[email protected]>
@bhashemian bhashemian disabled auto-merge May 16, 2022 01:10
@bhashemian bhashemian enabled auto-merge (squash) May 16, 2022 01:10
@bhashemian
Copy link
Copy Markdown
Member Author

bhashemian commented May 16, 2022

Hi @wyli, I added support for Compose/OneOf of Compose/OneOf. do you have any other comment? thanks.

wyli
wyli reviewed May 17, 2022
View reviewed changes
wyli
wyli reviewed May 17, 2022
View reviewed changes
wyli
wyli reviewed May 17, 2022
View reviewed changes
wyli
wyli reviewed May 17, 2022
View reviewed changes
wyli
wyli reviewed May 17, 2022
View reviewed changes
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 18, 2022

/build

@bhashemian bhashemian merged commit db32095 into Project-MONAI:dev May 18, 2022
@bhashemian bhashemian deleted the update-nvtx-range branch May 18, 2022 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bhashemian @wyli