Skip to content

4246 integration meta#4248

Merged
wyli merged 4 commits intofeature/MetaTensorfrom
4246-integration-meta
May 10, 2022
Merged

4246 integration meta#4248
wyli merged 4 commits intofeature/MetaTensorfrom
4246-integration-meta

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented May 9, 2022

Fixes #4246

Description

fixes integration tests for feature/MetaTensor

Status

Ready (needs to fix #4235 first)

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 3 commits May 9, 2022 19:31
@wyli
temp tests
6a8296b 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
fixes fast training
ba22337 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
seg 3d
1266545 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested review from Nic-Ma and rijobro May 9, 2022 22:38
@wyli
revert temp tests
764ad07 
Signed-off-by: Wenqi Li <[email protected]>
@rijobro rijobro marked this pull request as ready for review May 10, 2022 07:29
rijobro
rijobro approved these changes May 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@rijobro rijobro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the speedy fixes!

@wyli wyli merged commit fd1f005 into feature/MetaTensor May 10, 2022
@wyli wyli deleted the 4246-integration-meta branch May 10, 2022 09:55
wyli added a commit that referenced this pull request May 11, 2022
@wyli
4246 integration meta (#4248)
ca64702 
* temp tests

Signed-off-by: Wenqi Li <[email protected]>

* fixes fast training

Signed-off-by: Wenqi Li <[email protected]>

* seg 3d

Signed-off-by: Wenqi Li <[email protected]>

* revert temp tests

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli mentioned this pull request May 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rijobro rijobro rijobro approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wyli @rijobro