Skip to content

box utils#4244

Closed
Can-Zhao wants to merge 7 commits intoProject-MONAI:devfrom
Can-Zhao:detection_pr
Closed

box utils#4244
Can-Zhao wants to merge 7 commits intoProject-MONAI:devfrom
Can-Zhao:detection_pr

Conversation

@Can-Zhao
Copy link
Copy Markdown
Collaborator

@Can-Zhao Can-Zhao commented May 9, 2022 •
edited
Loading

Fixes #3571 .

Description

Add box util components

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Can-Zhao Can-Zhao added this to the Detection module [P0] milestone May 9, 2022
@wyli
Copy link
Copy Markdown
Contributor

wyli commented May 9, 2022

Hi Can, could you sign the commits https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work

@Can-Zhao Can-Zhao force-pushed the detection_pr branch 2 times, most recently from 6c5d0ee to 4e4b857 Compare May 9, 2022 14:01
@Can-Zhao
add default mode for a func
bcf58aa 
add unit test

add unit test

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

add unit test

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci
@Can-Zhao
Copy link
Copy Markdown
Collaborator Author

Can-Zhao commented May 9, 2022

Hi Can, could you sign the commits https://github.com/Project-MONAI/MONAI/blob/dev/CONTRIBUTING.md#signing-your-work

Thank you Wenqi. I squashed the commits and sign it

@Can-Zhao Can-Zhao marked this pull request as ready for review May 11, 2022 03:51
@Can-Zhao Can-Zhao closed this May 11, 2022
@Can-Zhao Can-Zhao deleted the detection_pr branch May 11, 2022 04:06
@Can-Zhao Can-Zhao mentioned this pull request May 24, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli Awaiting requested review from wyli

@dongyang0122 dongyang0122 Awaiting requested review from dongyang0122

@mibaumgartner mibaumgartner Awaiting requested review from mibaumgartner

Assignees

No one assigned

Labels

Feature request

Projects

None yet

Milestone

Detection module [P0]

Development

Successfully merging this pull request may close these issues.

Box utils components

2 participants

@Can-Zhao @wyli