Skip to content

Update the default value of lazy arg in the ConfigParser to True#4203

Merged
wyli merged 9 commits intoProject-MONAI:devfrom
Nic-Ma:update-parser-lazy
Apr 30, 2022
Merged

Update the default value of lazy arg in the ConfigParser to True#4203
wyli merged 9 commits intoProject-MONAI:devfrom
Nic-Ma:update-parser-lazy

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Apr 29, 2022

Description

During the development of bundle examples and scripts, I realized that it's better to use lazy=True as default value in the ConfigParser to continuously load components. For example, actually we already use it in the run script:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/bundle/scripts.py#L373
And here is another typical example code:

parser = ConfigParser()
parser.read_config(config_file)

# instantialize the components
model = parser.get_parsed_content("network")
model.load_state_dict(torch.load(ckpt_path))

dataloader = parser.get_parsed_content("dataloader")
inferer = parser.get_parsed_content("inferer")
postprocessing = parser.get_parsed_content("postprocessing")

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 30, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 30, 2022

/build

@wyli wyli merged commit d4a924c into Project-MONAI:dev Apr 30, 2022
Can-Zhao pushed a commit to Can-Zhao/MONAI that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants