Skip to content

4165 add adn option to unet#4185

Merged
ericspod merged 4 commits intoProject-MONAI:devfrom
wyli:adds-unet-option
Apr 27, 2022
Merged

4165 add adn option to unet#4185
ericspod merged 4 commits intoProject-MONAI:devfrom
wyli:adds-unet-option

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Apr 26, 2022

Signed-off-by: Wenqi Li [email protected]

discussed in #4165

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli changed the title 4165 add adn unet 4165 add adn option to unet Apr 26, 2022
@wyli wyli requested review from ericspod and yiheng-wang-nv April 27, 2022 12:32
@wyli wyli marked this pull request as ready for review April 27, 2022 12:32
Copy link
Copy Markdown
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the ordering default value in the new constructor argumentfor UNet is what it was set in ADN so this shouldn't break any stored models.

@ericspod ericspod enabled auto-merge (squash) April 27, 2022 20:56
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Apr 27, 2022

/build

@ericspod ericspod merged commit df177fd into Project-MONAI:dev Apr 27, 2022
@wyli wyli deleted the adds-unet-option branch April 27, 2022 22:33
Can-Zhao pushed a commit to Can-Zhao/MONAI that referenced this pull request May 10, 2022
Signed-off-by: Wenqi Li <[email protected]>

Co-authored-by: Eric Kerfoot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants