Skip to content

4172 aggregate with buffer copy#4174

Merged
wyli merged 8 commits intoProject-MONAI:devfrom
wyli:4172-copy-buffer
Apr 27, 2022
Merged

4172 aggregate with buffer copy#4174
wyli merged 8 commits intoProject-MONAI:devfrom
wyli:4172-copy-buffer

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Apr 25, 2022 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

Fixes #4172
Fixes #4176

Description

copy the buffer when aggregating.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Apr 25, 2022

/build

@wyli wyli marked this pull request as ready for review April 25, 2022 20:57
Nic-Ma
Nic-Ma approved these changes Apr 26, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix.

@Nic-Ma Nic-Ma mentioned this pull request Apr 26, 2022
Closed
@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Apr 26, 2022

Mark: may also cover #4176 in this PR.

Thanks.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Apr 27, 2022

/build

@wyli wyli enabled auto-merge (squash) April 27, 2022 07:42
@wyli
add tests
0641a3e 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Apr 27, 2022

/build

@wyli wyli merged commit 5c15138 into Project-MONAI:dev Apr 27, 2022
@wyli wyli deleted the 4172-copy-buffer branch April 28, 2022 12:24
Can-Zhao pushed a commit to Can-Zhao/MONAI that referenced this pull request May 10, 2022
@wyli @Can-Zhao
4172 aggregate with buffer copy (Project-MONAI#4174)
4e05c41 
* fixes Project-MONAI#4172 aggregate with no in-place buffer change

Signed-off-by: Wenqi Li <[email protected]>

* update reduction option

Signed-off-by: Wenqi Li <[email protected]>

* fixes flake8

Signed-off-by: Wenqi Li <[email protected]>

* update

Signed-off-by: Wenqi Li <[email protected]>

* adds tests

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@yiheng-wang-nv yiheng-wang-nv Awaiting requested review from yiheng-wang-nv

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

reduction argument for DiceMetric.aggregate()? run DiceMetric.aggregate() more than once produce inaccurate results

2 participants

@wyli @Nic-Ma