Skip to content

4167 enhance bundle run logic#4168

Merged
wyli merged 16 commits intoProject-MONAI:devfrom
Nic-Ma:4167-enhance-bundle-logic
Apr 27, 2022
Merged

4167 enhance bundle run logic#4168
wyli merged 16 commits intoProject-MONAI:devfrom
Nic-Ma:4167-enhance-bundle-logic

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Apr 25, 2022 •
edited
Loading

Fixes #4167 .

Description

This PR enhanced the execution logic of bundler run.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma Nic-Ma requested a review from wyli April 25, 2022 09:16
@Nic-Ma Nic-Ma changed the title [WIP] 4167 enhance bundle run logic 4167 enhance bundle run logic Apr 25, 2022
@Nic-Ma Nic-Ma marked this pull request as ready for review April 25, 2022 13:49
@Nic-Ma Nic-Ma requested review from ericspod and rijobro April 25, 2022 13:49
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 25, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 26, 2022

Hi @wyli ,

I updated the PR according to your comments, could you please help review it again?

Thanks in advance.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 26, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 26, 2022

/build

ericspod
ericspod approved these changes Apr 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this is more general.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 26, 2022 •
edited
Loading

Hi @ericspod ,

Thanks for your review, a typical multi-gpu example can be:

"training": [
    "$dist.init_process_group(backend='nccl')",
    "$torch.cuda.set_device(@device)",
    "$monai.utils.set_determinism(seed=123)",
    "$@train#trainer.run()",
    "$dist.destroy_process_group()"
]

Currently, we use python Set to save references which can't guarantee the list order:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/bundle/reference_resolver.py#L250
Let me try to also update it in this PR.

Thanks.

@ericspod
Copy link
Copy Markdown
Member

ericspod commented Apr 26, 2022

Currently, we use python Set to save references which can't guarantee the list order: https://github.com/Project-MONAI/MONAI/blob/dev/monai/bundle/reference_resolver.py#L250 Let me try to also update it in this PR.

Thanks.

Yes we should use list also because statements might be duplicated.

@Nic-Ma Nic-Ma mentioned this pull request Apr 26, 2022
Merged
1 task
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 26, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 26, 2022

/build

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 26, 2022

Hi @wyli @ericspod ,

This PR is ready, do you have any other comments?

Thanks in advance.

wyli
wyli reviewed Apr 26, 2022
View reviewed changes
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 27, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Apr 27, 2022

/build

@wyli wyli merged commit cc17f38 into Project-MONAI:dev Apr 27, 2022
Can-Zhao pushed a commit to Can-Zhao/MONAI that referenced this pull request May 10, 2022
@Nic-Ma @Can-Zhao
4167 enhance bundle run logic (Project-MONAI#4168)
11d821f 
* [DLMED] enhance CLI runner_id

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] optimize config logic

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] fix list order

Signed-off-by: Nic Ma <[email protected]>

* [DLMED] update according to comments

Signed-off-by: Nic Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli left review comments

@ericspod ericspod ericspod approved these changes

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need to enhance the logic control of bundle config

3 participants

@Nic-Ma @ericspod @wyli