Add DeepEdit transforms and interaction#4164
Merged
wyli merged 22 commits intoProject-MONAI:devfrom Apr 27, 2022
Merged
Conversation
Signed-off-by: Andres Diaz-Pinto <[email protected]>
Signed-off-by: Andres Diaz-Pinto <[email protected]>
Signed-off-by: Andres Diaz-Pinto <[email protected]>
diazandr3s
commented
Apr 26, 2022
Signed-off-by: Andres Diaz-Pinto <[email protected]>
wyli
reviewed
Apr 26, 2022
Signed-off-by: Andres Diaz-Pinto <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Andres Diaz-Pinto <[email protected]>
Signed-off-by: Andres Diaz-Pinto <[email protected]>
Signed-off-by: Andres Diaz-Pinto <[email protected]>
Signed-off-by: Andres Diaz-Pinto <[email protected]>
Signed-off-by: Andres Diaz-Pinto <[email protected]>
Signed-off-by: Andres Diaz-Pinto <[email protected]>
wyli
reviewed
Apr 27, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
Thanks @diazandr3s, the PR looks good, I put only some minor comments inline, mainly to remove unused comments and renaming the components for clarity, please consider. There are automatic warnings https://deepsource.io/gh/Project-MONAI/MONAI/run/f3635017-30df-4abf-afc4-32f406d4a57c/python/ please also help revise if possible (this part is optional but I think some of the suggestions are useful).
Signed-off-by: Andres Diaz-Pinto <[email protected]>
Signed-off-by: Andres Diaz-Pinto <[email protected]>
Contributor
|
/black |
Signed-off-by: Andres Diaz-Pinto <[email protected]>
wyli
approved these changes
Apr 27, 2022
Contributor
|
/build |
1 similar comment
Contributor
|
/build |
wyli
changed the title
Can-Zhao
pushed a commit
to Can-Zhao/MONAI
that referenced
this pull request
May 10, 2022
* Add DeepEdit transforms and interaction Signed-off-by: Andres Diaz-Pinto <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andres Diaz-Pinto [email protected]
Description
These changes help to reduce code in MONAI Label repo and DeepEdit tutorial
Status
Ready