Merged
Conversation
Signed-off-by: Yiheng Wang <[email protected]>
Contributor
|
Would be necessary to also this option in other metrics? I am not sure about that. Thanks in advance. |
Member
|
I stated in the original issue before noticing this, but with the dice loss we have two distinct values for smoothing the numerator and denominator which can be set to allow the user to select which way to handle empty ground truths. I think we should have the same solution here for consistency rather than a special case for when the ground truth is empty. |
wyli
reviewed
Apr 27, 2022
wyli
approved these changes
Apr 28, 2022
Contributor
wyli
left a comment
wyli
left a comment
There was a problem hiding this comment.
I think this change improves the current dev codebase.
Contributor
|
/build |
Contributor
|
/build |
Can-Zhao
pushed a commit
to Can-Zhao/MONAI
that referenced
this pull request
May 10, 2022
Signed-off-by: Yiheng Wang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang [email protected]
Fixes #4160 .
Description
This PR enhances the
DiceMetricvia adding an option to handle the empty ground truth cases.Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.