/black

/build

/build

Is the future annotations necessary or purely aesthetic? I would leave it if it's the latter. Even though I find a | None more intuitive than Optional[a], we probably don't want to be doing this piecemeal in the codebase.

Hi @ericspod ,

I updated the engines in this PR, and I checked all the handlers don't have dependency on Workflow, so keep them with ignite Engine.
Seems pre-commit-ci also automatically changed several typehints, I saw @rijobro also used similar thing in MetaTensor:
https://github.com/Project-MONAI/MONAI/blob/dev/monai/data/meta_tensor.py
Maybe this is the right way to go? We may need to automatically update all the typehints in the codebase with the pre-commit-ci tool later (I don't know how to trigger it..).
Could you please help the PR?

Thanks in advance.

So you imported from __future__ import annotations so that you could use SupervisedEvaluator as type hint for engine in _iteration?

And then from there, the pre-commit-ci made the other type hint changes (a | None)? If that's the case, this is all OK with me.

So you imported from __future__ import annotations so that you could use SupervisedEvaluator as type hint for engine in _iteration?

And then from there, the pre-commit-ci made the other type hint changes (a | None)? If that's the case, this is all OK with me.

Hi @rijobro ,

Yes, I imported the annotations to make current class is available for typehints.

Thanks.

/build

Hi @rijobro ,

The initial discussion about this PR is here: #4132 (comment).

Thanks.

I executed the integration test test_integration_workflows.py locally and it passed OK.

Thanks.

I'm good with the changes, this way of defining optional values should be compatible with the versions of Python we're supporting now.