Skip to content

extending the mlp module#4089

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
wyli:extend-mlp
Apr 10, 2022
Merged

extending the mlp module#4089
wyli merged 4 commits intoProject-MONAI:devfrom
wyli:extend-mlp

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Apr 7, 2022 •
edited
Loading

Signed-off-by: Wenqi Li [email protected]

Description

(this is a follow-up of PR #4074 and the discussions.)

This PR extends the MLPBlock (multi-layer perceptron) with

  • configurable activation function
  • shared or independent dropout instances

the refactoring is inspired by #4074 #4074 (comment) and the goal is to

  • enhance the flexibility of the essential building blocks and
  • encourage the reuse of the existing components when bringing in new network models.

previously trained models (such as MMAR) can still be used with this update
verified: https://github.com/Project-MONAI/MONAI/runs/5881423584?check_suite_focus=true

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

wyli added 2 commits April 7, 2022 20:34
@wyli
extend mlp
709a849 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
0 mlp_dim
55703fe 
Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Apr 8, 2022

this is compatible with previously released model weights, verified here https://github.com/Project-MONAI/MONAI/runs/5881423584?check_suite_focus=true

@wyli wyli marked this pull request as ready for review April 8, 2022 07:45
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Apr 8, 2022

/build

@ericspod
Copy link
Copy Markdown
Member

ericspod commented Apr 8, 2022

I would add some description or comment explaining why this is done and what the meaning is of the modes.

@ahatamiz
Copy link
Copy Markdown
Contributor

ahatamiz commented Apr 9, 2022

Looks good. Please merge so we can update the swin unetr PR.

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Apr 10, 2022

Hi @wyli ,

I think @yiheng-wang-nv @ahatamiz approved the PR, do you have any missing parts to add or update?

Thanks.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Apr 10, 2022

/build

@wyli wyli enabled auto-merge (squash) April 10, 2022 06:40
@wyli wyli merged commit 17529e7 into Project-MONAI:dev Apr 10, 2022
@wyli wyli deleted the extend-mlp branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiheng-wang-nv yiheng-wang-nv yiheng-wang-nv approved these changes

@Nic-Ma Nic-Ma Awaiting requested review from Nic-Ma Nic-Ma is a code owner

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wyli @ericspod @ahatamiz @Nic-Ma @yiheng-wang-nv