Update cuCIM min dependency to support random transforms#4004
Merged
wyli merged 3 commits intoProject-MONAI:devfrom Mar 26, 2022
Merged
Update cuCIM min dependency to support random transforms#4004wyli merged 3 commits intoProject-MONAI:devfrom
wyli merged 3 commits intoProject-MONAI:devfrom
Conversation
Signed-off-by: Behrooz <[email protected]>
wyli
approved these changes
Mar 25, 2022
Contributor
|
/build |
Contributor
|
(there's an irrelevant issue affecting #4003 I'll fix it and merge this PR) |
Contributor
|
looks like the cucim pypi update breaks a test here https://github.com/Project-MONAI/MONAI/runs/5695808906?check_suite_focus=true#step:7:22030 |
Member
Author
|
That's weird. I'll check on the test. |
Nic-Ma
approved these changes
Mar 26, 2022
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The new release of cuCIM (22.2.1) includes important updates to the random transforms, where the randomness is apply per-image instead of per-batch which was the case in the previous versions. Our updated pathology tutorials depend on this version to work so it should be set as the minimum version in MONAI.
Status
Ready
Types of changes