Skip to content

3983 Remove ambiguous or ops for optional args#3997

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
yiheng-wang-nv:3983-remove-ambiguous-or-operations
Mar 24, 2022
Merged

3983 Remove ambiguous or ops for optional args#3997
wyli merged 2 commits intoProject-MONAI:devfrom
yiheng-wang-nv:3983-remove-ambiguous-or-operations

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

Signed-off-by: Yiheng Wang [email protected]

Fixes #3983 .

Description

I checked all patterns A or self.A in monai/transforms/, and change them into self.A if A is None else A if self.A is an optional argument.
The changed args include spatial_size and align_corners.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv yiheng-wang-nv requested a review from wyli March 24, 2022 15:09
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 24, 2022

/build

1 similar comment
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 24, 2022

/build

@wyli wyli enabled auto-merge (squash) March 24, 2022 20:15
@wyli wyli merged commit b91faa2 into Project-MONAI:dev Mar 24, 2022
@yiheng-wang-nv yiheng-wang-nv deleted the 3983-remove-ambiguous-or-operations branch March 25, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RandZoomd align_corners incorrect

2 participants