3962 Update CacheDataset num workers#3963
Merged
wyli merged 4 commits intoProject-MONAI:devfrom Mar 17, 2022
Merged
Conversation
Signed-off-by: Yiheng Wang <[email protected]>
Nic-Ma
reviewed
Mar 17, 2022
wyli
approved these changes
Mar 17, 2022
Contributor
|
/build |
1 similar comment
Contributor
|
/build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang [email protected]
Fixes #3962 .
Description
In this PR, the default value of
num_workersis set to 1 forCacheDatasetand all its subclasses. Some of the subclasses use the value 0, although it will be replaced by 1 automatically, zero thread is meaningless and it is actually an illegal input formultiprocessing.pool.ThreadPool(used within theCacheDataset, the source code of it is in here) thus I also modified them.In addition, this PR also fixes a few typos and unify the docstrings for same arguments in different classes.
Status
Ready
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.