Skip to content

3940 optional meta_file in bundle run#3952

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:3940-meta-file-optional
Mar 17, 2022
Merged

3940 optional meta_file in bundle run#3952
wyli merged 2 commits intoProject-MONAI:devfrom
wyli:3940-meta-file-optional

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Mar 16, 2022

Signed-off-by: Wenqi Li [email protected]

Fixes #3940

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli
optional meta_file
e8c52a2 
Signed-off-by: Wenqi Li <[email protected]>
@wyli wyli requested a review from Nic-Ma March 16, 2022 12:11
Nic-Ma
Nic-Ma approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good to me.
Could you please help change the data_dir environment related items from metadata.json to the inference.json?
If you don't want to include it in this PR, it's OK, I can do it later.

Thanks.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Mar 16, 2022

/integration-test

@Nic-Ma
Copy link
Copy Markdown
Contributor

Nic-Ma commented Mar 17, 2022

Hi @wyli ,

I already adjusted the dataset_dir config in: #3927.

Thanks.

@wyli wyli marked this pull request as ready for review March 17, 2022 11:20
@wyli wyli enabled auto-merge (squash) March 17, 2022 12:55
@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Mar 17, 2022

/build

@wyli wyli merged commit 55e6018 into Project-MONAI:dev Mar 17, 2022
@wyli wyli deleted the 3940-meta-file-optional branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nic-Ma Nic-Ma Nic-Ma approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

make 'meta_file' optional for monai.bundle run

2 participants

@wyli @Nic-Ma