Skip to content

3922 Make UNETR support torchscript#3923

Merged
wyli merged 3 commits intoProject-MONAI:devfrom
yiheng-wang-nv:enhance-unetr-for-torchscript
Mar 11, 2022
Merged

3922 Make UNETR support torchscript#3923
wyli merged 3 commits intoProject-MONAI:devfrom
yiheng-wang-nv:enhance-unetr-for-torchscript

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Mar 11, 2022 •
edited by wyli
Loading

Signed-off-by: Yiheng Wang [email protected]

Fixes #3922 .

Description

This PR makes UNETR support torchscript, and it also changes some unit test typos.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@yiheng-wang-nv yiheng-wang-nv requested review from ahatamiz and wyli and removed request for ahatamiz March 11, 2022 04:04
@ahatamiz
Copy link
Copy Markdown
Contributor

ahatamiz commented Mar 11, 2022

/build

@ahatamiz
Copy link
Copy Markdown
Contributor

ahatamiz commented Mar 11, 2022

@yiheng-wang-nv Thanks for the quick action regarding Torchscript support. Everything looks good to me.

@wyli I think this can be merged without any issues.

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor Author

yiheng-wang-nv commented Mar 11, 2022

There is a mypy error, but it seems not relate to this PR ( https://github.com/Project-MONAI/MONAI/runs/5506206637?check_suite_focus=true#step:7:466) I checked with the dev branch and found the same error locally.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 11, 2022

There is a mypy error, but it seems not relate to this PR ( https://github.com/Project-MONAI/MONAI/runs/5506206637?check_suite_focus=true#step:7:466) I checked with the dev branch and found the same error locally.

yes this is from torch update, I had a fix in #3832. I'll merge this PR soon.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 11, 2022

/build

@wyli wyli enabled auto-merge (squash) March 11, 2022 09:12
@wyli wyli merged commit 38b6437 into Project-MONAI:dev Mar 11, 2022
@yiheng-wang-nv yiheng-wang-nv deleted the enhance-unetr-for-torchscript branch March 15, 2022 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli Awaiting requested review from wyli

1 more reviewer

@ahatamiz ahatamiz ahatamiz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

network UNETR does not support torchscript

3 participants

@yiheng-wang-nv @ahatamiz @wyli