Skip to content

3904 improve output_transform of handlers#3913

Merged
Nic-Ma merged 9 commits intoProject-MONAI:devfrom
Nic-Ma:3904-improve-output
Mar 12, 2022
Merged

3904 improve output_transform of handlers#3913
Nic-Ma merged 9 commits intoProject-MONAI:devfrom
Nic-Ma:3904-improve-output

Conversation

@Nic-Ma
Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma commented Mar 9, 2022 •
edited
Loading

Fixes #3904 .

Description

This PR added the ignore_data API to improve user experience when avoiding logging with lambda x: None in handlers.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 9, 2022

/integration-test

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 9, 2022

I already verified the workflow integration test locally.

Thanks.

@Nic-Ma Nic-Ma requested review from ericspod, rijobro and wyli March 9, 2022 15:32
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 9, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 9, 2022

/build

@Nic-Ma Nic-Ma changed the title 3904 improve output_transform of handlers [WIP] 3904 improve output_transform of handlers Mar 10, 2022
wyli
wyli approved these changes Mar 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I think the API becomes intuitive now

@Nic-Ma
[DLMED] fix mypy
ea2671c 
Signed-off-by: Nic Ma <[email protected]>
@Nic-Ma Nic-Ma changed the title [WIP] 3904 improve output_transform of handlers 3904 improve output_transform of handlers Mar 12, 2022
@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 12, 2022

/black

@Nic-Ma
Copy link
Copy Markdown
Contributor Author

Nic-Ma commented Mar 12, 2022

/build

@Nic-Ma Nic-Ma enabled auto-merge (squash) March 12, 2022 11:22
@Nic-Ma Nic-Ma merged commit 7587e71 into Project-MONAI:dev Mar 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wyli wyli wyli approved these changes

@ericspod ericspod Awaiting requested review from ericspod ericspod is a code owner

@rijobro rijobro Awaiting requested review from rijobro

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve output_transform for StatsHandler

2 participants

@Nic-Ma @wyli