Skip to content

3883 Add addition shape info when raise related errors#3896

Merged
wyli merged 4 commits intoProject-MONAI:devfrom
yiheng-wang-nv:3883-additional-info-for-shape
Mar 7, 2022
Merged

3883 Add addition shape info when raise related errors#3896
wyli merged 4 commits intoProject-MONAI:devfrom
yiheng-wang-nv:3883-additional-info-for-shape

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

Fixes #3883 .

Description

The way to find the places that should be modified is by using the following regular expression without case sensivity:

.*error.*shape

Therefore, there may still have some places that are not covered.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv yiheng-wang-nv changed the title 3883 additional info for shape 3883 Add addition shape info when raise related errors Mar 7, 2022
@yiheng-wang-nv yiheng-wang-nv requested review from Nic-Ma and wyli March 7, 2022 09:59
Copy link
Copy Markdown
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 7, 2022

/build

@wyli wyli enabled auto-merge (squash) March 7, 2022 11:06
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 7, 2022

/black

@wyli wyli merged commit 16ea7d6 into Project-MONAI:dev Mar 7, 2022
@yiheng-wang-nv yiheng-wang-nv deleted the 3883-additional-info-for-shape branch March 7, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

additional info when the shapes don't match

2 participants