Skip to content

3879 Fix TestKeepLargestConnectedComponent issue#3895

Merged
wyli merged 2 commits intoProject-MONAI:devfrom
yiheng-wang-nv:3879-fix-keep-largest-connected-component
Mar 7, 2022
Merged

3879 Fix TestKeepLargestConnectedComponent issue#3895
wyli merged 2 commits intoProject-MONAI:devfrom
yiheng-wang-nv:3879-fix-keep-largest-connected-component

Conversation

@yiheng-wang-nv
Copy link
Copy Markdown
Contributor

Signed-off-by: Yiheng Wang [email protected]

Fixes #3879 .

Description

This PR fixes the issue via:

  1. Skip some unit tests before torch==1.7, and add some notes to clarify the resons.
  2. Use deepcopy for input_image if it has further usage.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv yiheng-wang-nv requested a review from wyli March 7, 2022 08:43
@wyli
Copy link
Copy Markdown
Contributor

wyli commented Mar 7, 2022

/build

@wyli wyli merged commit 2ffad76 into Project-MONAI:dev Mar 7, 2022
@yiheng-wang-nv yiheng-wang-nv deleted the 3879-fix-keep-largest-connected-component branch March 7, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

torch 1.6 unit test test_keep_largest_connected_component

2 participants