Skip to content

support of writer name as option in SaveImage#3885

Merged
wyli merged 5 commits intoProject-MONAI:devfrom
wyli:support-writer-name
Mar 7, 2022
Merged

support of writer name as option in SaveImage#3885
wyli merged 5 commits intoProject-MONAI:devfrom
wyli:support-writer-name

Conversation

@wyli
Copy link
Copy Markdown
Contributor

@wyli wyli commented Mar 2, 2022

Description

add support of

SaveImaged(keys="img", output_postfix="itk", writer="ITKWriter")(data_in)

as a shortcut of

from monai.data import ITKWriter
SaveImaged(keys="img", output_postfix="itk", writer=ITKWriter)(data_in)

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

@wyli wyli force-pushed the support-writer-name branch from 5bce5ed to bbaac4f Compare March 3, 2022 20:02
@wyli wyli force-pushed the support-writer-name branch from bbaac4f to 9a474da Compare March 3, 2022 20:06
@pxLi
Copy link
Copy Markdown
Contributor

pxLi commented Mar 7, 2022

/build

1 similar comment
@pxLi
Copy link
Copy Markdown
Contributor

pxLi commented Mar 7, 2022

/build

Copy link
Copy Markdown
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update.
Looks good to me, put a minor comment inline.

Thanks.

@wyli
Copy link
Copy Markdown
Contributor Author

wyli commented Mar 7, 2022

/build

@wyli wyli enabled auto-merge (squash) March 7, 2022 10:04
@wyli wyli merged commit 8e588e7 into Project-MONAI:dev Mar 7, 2022
@wyli wyli deleted the support-writer-name branch April 27, 2022 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants